feat: DSPX-2580 key management quickstart provider root key example#234
feat: DSPX-2580 key management quickstart provider root key example#234eugenioenko wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds documentation for using the key-management KEY_MODE_PROVIDER_ROOT_KEY flow in the quickstart, clarifying how to register keys where wrapping/unwrapping is delegated to an external KMS/HSM while the wrapped key material is still stored in the platform DB.
Changes:
- Replace the previous “remote key reference” transition text with an explanation + example request for KEY_MODE_PROVIDER_ROOT_KEY
- Document the field-level differences between
KEY_MODE_CONFIG_ROOT_KEYandKEY_MODE_PROVIDER_ROOT_KEY(includingprovider_config_id) - Update the “Important additional comments” note to include
KEY_MODE_PROVIDER_ROOT_KEYfor base64wrapped_keyexpectations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the key management quickstart documentation by integrating an example for KEY_MODE_PROVIDER_ROOT_KEY. This addition clarifies how users can configure the platform to utilize external Key Management Systems (KMS) or Hardware Security Modules (HSM) for wrapping private keys, thereby improving flexibility and security for key storage. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a new example for KEY_MODE_PROVIDER_ROOT_KEY to the key management quickstart documentation. The changes are clear and provide a good explanation of this key mode. I've made one suggestion to improve the consistency of the new JSON example to avoid potential confusion for users.
Note: Security Review has been skipped due to the limited scope of the PR.
4da9bd4 to
6465ef6
Compare
6465ef6 to
8b1a9a7
Compare
| }, | ||
| "private_key_ctx": { | ||
| "wrapped_key": "<base64-encoded-wrapped-private-key>", | ||
| "key_id": "arn:aws:kms:us-east-1:123456789012:key/mrk-1234abcd-12ab-34cd-56ef-1234567890ab", |
There was a problem hiding this comment.
Maybe use a generic provider_id. Don't want to imply AWS KMS support in OpenTDF. Also please scrub for any other AWS KMS references in the doc
| - **private_key_ctx.wrapped_key** contains the private key already wrapped (encrypted) by the external KMS/HSM, base64-encoded. The platform stores this ciphertext and delegates unwrapping to the external KMS/HSM at rewrap time. | ||
| - **private_key_ctx.key_id** identifies the specific wrapping key within the provider (e.g. a KMS key ID or alias). KAS uses this when it needs to unwrap the private key during a rewrap operation. | ||
|
|
||
| ### KEY_MODE_REMOTE (mode 3) |
There was a problem hiding this comment.
Can we standardize terminology to use envelope mode (2) and delegated mode (3)?
Pull request overview
Adds documentation for using the key-management KEY_MODE_PROVIDER_ROOT_KEY flow in the quickstart, clarifying how to register keys where wrapping/unwrapping is delegated to an external KMS/HSM while the wrapped key material is still stored in the platform DB.