Add plan to implement INFP-504#885
Add plan to implement INFP-504#885gmazoyer wants to merge 2 commits intopog-artifact-composition-specfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (4)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| ```python | ||
| class InfrahubFilters: | ||
| def __init__(self, client: InfrahubClient) -> None: | ||
| self.client = client |
There was a problem hiding this comment.
I'm not sure that it's correct, but the way I saw this was that a client param here would be optional. That way we can initialize a Template class the same way and then if we specifically want to use these filters we'd use some setter afterwards to add the client. However this might not be required depending on how we end up populating these filters into the template class in various circumstances.
Deploying infrahub-sdk-python with
|
| Latest commit: |
56476d3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://93e54eb5.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://gma-20260323-infp504-plan.infrahub-sdk-python.pages.dev |
2 participants
This PR only provides the implementation plan for INFP-504 - Artifact composition. It proposes a way to implement Jinja2 filters in order to be able to include the content of an artifact or a file object within another one.