AO3-6218 Allow certain admins to access all collection and challenge pages usually reserved for owners#5592
Conversation
…pages usually reserved for owners
Bilka2
left a comment
There was a problem hiding this comment.
Please use pundit for the access control. You can find our existing policies in the app/policies folder if you'd like examples. The other issues on the admin role Epic also have examples of pundit implementations.
Since this is a rather big PR already just with the permission changes, I would prefer if you didn't action unrelated rubocop issues, like the i18n changes you did here. The risk that something accidentally breaks is just too big there to include it all with the permission changes.
For the specs, please use the an action only authorized admins can access shared example if possible, it tests a lot of admin roles automatically. Examples for it's use can be found all across the admin role tests.
b01187c to
e408677
Compare
|
Hey- I dont have a way to get this out of "Coder has reviewed action" tag but I'm still working on it. |
|
it's ready to be reviewed :) |
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6218
Purpose
Allow admins with
support,policy_and_abuse, orsuperadminroles to access owner/maintainer collection and challenge pages for viewing/troubleshooting, without granting write permissions.Implemented via shared controller helpers and action-level filter changes so read routes are opened for those roles while create/update/destroy paths remain owner/maintainer-only.
Testing Instructions
Automated coverage was added/updated for the affected controllers to verify:
(Functional QA flow is already documented in the Jira ticket.)
Credit
varram (he/him)