Skip to content

Allow \ in setvar#3519

Open
JonathanBerrew wants to merge 1 commit intoowasp-modsecurity:v2/masterfrom
JonathanBerrew:Allow-backslash-in-setvar
Open

Allow \ in setvar#3519
JonathanBerrew wants to merge 1 commit intoowasp-modsecurity:v2/masterfrom
JonathanBerrew:Allow-backslash-in-setvar

Conversation

@JonathanBerrew
Copy link

This is a Marc Stern modification, I don't have much more insight on the code he made. To be reviewed with caution and check if this is still relevant

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@airween
Copy link
Member

airween commented Mar 18, 2026

Hi @JonathanBerrew,

it would be nice to explain the reason with an example, why it is necessary and in which case is it useful to allow \ in setvar action.

@JonathanBerrew
Copy link
Author

Sadly I don't know why Marc made those modifications, I wasn't working on the project at the time. If this seem unnecessary, you can close the PR

@airween
Copy link
Member

airween commented Mar 19, 2026

Sadly I don't know why Marc made those modifications, I wasn't working on the project at the time. If this seem unnecessary, you can close the PR

I see. I don't want to close this PR without any reason. If Marc made this modification, that means it's possible useful, but I would like to understand it. Beside of that, we need to documentation the behavior, and give examples to users, so this is why it would be good.

@fzipi
Copy link
Collaborator

fzipi commented Mar 19, 2026

No tests, and no use cases. 🤷 I'll close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants