Skip to content

[FIX] add margin in members list for long display names#4800

Open
rohan-jadhav-dev wants to merge 2 commits intoowncloud:masterfrom
rohan-jadhav-dev:fix/spaces-member-name-margin-4781
Open

[FIX] add margin in members list for long display names#4800
rohan-jadhav-dev wants to merge 2 commits intoowncloud:masterfrom
rohan-jadhav-dev:fix/spaces-member-name-margin-4781

Conversation

@rohan-jadhav-dev
Copy link

@rohan-jadhav-dev rohan-jadhav-dev commented Mar 6, 2026

Fixes #4781

Summary

Fixes lack of right margin in the members list when display name is long.

Changes

  • Added layout_marginEnd to the container LinearLayout to prevent overflow
  • ellipsize stays as middle for consistency with the rest of the app

Testing

  • Tested with long display name "Jose Rodriguez Perez Martinez Lopez Garcia"
  • Verified name truncates properly with "..." in the middle
  • Verified with Can view role (no edit/delete buttons)
  • Verified with Can edit role

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2026

CLA assistant check
All committers have signed the CLA.

@jesmrec
Copy link
Collaborator

jesmrec commented Mar 6, 2026

Thanks for the contribution @rohan-jadhav-dev. I'll give you some tips that you will also find in our CONTRIBUTING file:

  • For the branch names, we use underscore to separate _ the chunks, like fix/spaces_member_name_margin_4781 . Also, the prefix to use should match the type of the issue. The issue you fixed starts with [FEATURE REQUEST], so, it should be feature/... Don't worry for that in the current PR, but please take in account for future contributions 😉

  • For the PR title, we use to add a prefix like [FIX], [BUG], [FEATURE REQUEST]... at the beginning. Check examples in the PR list

  • We use to follow Conventional Commits to name the commits. As you'd have realised, the CI checks below ⬇️ shows a red ❌ in the Conventional Commits check. For a quick summary check this. Basically, the commit name must start with a correct prefix (check here the ones that CI verifies). Please fix, you can amend the commit or fix it with an interactive rebase. Any question you could have about this processes just ping us and we will be pleasant to help you!! This is required to merge the PR.

  • In terms of CHANGELOG, every PR should contain changelog entry to briefly describe the work you did. You'll find how to do it in this link. In the changelog/ folder you'll find multiple examples (check unreleased folder for the newest ones). Also, in the list of closed PRs you will see the changelog file in every PR.

Any question about the process, @joragua or myself will be happy to help you!!

@jesmrec
Copy link
Collaborator

jesmrec commented Mar 6, 2026

About your solution for the given problem:

The ellipsize property should stay in the middle, since this way is implemented around the app. For consistency, every ellipsized string should be displayed in the same way everywhere in the app. The fix should be focused in the container's margin or padding properties and not in the text itself.

As you checked with and without the pencil and trashbin icons, it will be checked in QA-phase after the code review and the green CI.

Thanks a lot again!!

@rohan-jadhav-dev rohan-jadhav-dev force-pushed the fix/spaces-member-name-margin-4781 branch from 20eb5c3 to dd015dd Compare March 6, 2026 17:39
@rohan-jadhav-dev rohan-jadhav-dev changed the title Fix lack of margin in member name when displayname is long #4781 fix: add margin in members list for long display names Mar 6, 2026
@rohan-jadhav-dev rohan-jadhav-dev force-pushed the fix/spaces-member-name-margin-4781 branch from 948cc5c to d9c2b99 Compare March 6, 2026 17:56
@rohan-jadhav-dev rohan-jadhav-dev changed the title fix: add margin in members list for long display names [FIX] add margin in members list for long display names Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Lack of margin in the list of members when displayname is long

3 participants