Fix callable flag_value being instantiated when used as a default#3225
Open
kdeldycke wants to merge 1 commit intopallets:mainfrom
Open
Fix callable flag_value being instantiated when used as a default#3225kdeldycke wants to merge 1 commit intopallets:mainfrom
flag_value being instantiated when used as a default#3225kdeldycke wants to merge 1 commit intopallets:mainfrom
Conversation
Collaborator
Author
kdeldycke
force-pushed
the
keep-classes-flag-values-uninstanciated
branch
from
ead2d43 to
75d0590
Compare
kdeldycke
force-pushed
the
keep-classes-flag-values-uninstanciated
branch
from
90ea873 to
d898d6c
Compare
kdeldycke
force-pushed
the
keep-classes-flag-values-uninstanciated
branch
from
d898d6c to
de48f5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix issue #3121, where a
flag_valueset to a class produce an instance of that class in the particular case that it is explicitly set as the default.The fix consist in lazily resolving the default value at the time of use, with a branch dedicated to callables.
I extended the unittests to
default_mapto demonstrate the current state of callable presence in them.