Skip to content

feat: [sc-138627] Allow 48 kB cloud env asset OTA to device #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
monkbroc merged 2 commits into from
Mar 11, 2026
Merged

feat: [sc-138627] Allow 48 kB cloud env asset OTA to device #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ecc00c
Allow setting maximum env asset size
monkbroc Mar 10, 2026
5a9d0ec
4.0.1-rc.1
monkbroc Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/moduleEncoding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1682,13 +1682,14 @@ async function createProtectedModule(module, certificate) {
* @param {String|Buffer} snapshot.hash Snapshot hash. Can be a buffer or hex-encoded string.
* @param {String|Number} snapshot.updatedAt Snapshot creation time. Can be a string in a format
* supported by `Date.parse()` or a numeric timestamp.
* @param {Number} [maxSize=MAX_ENV_SIZE] Maximum allowed size of the resulting module.
* @returns {Promise<Buffer>} Asset data.
*/
async function encodeEnvVarsAsset(vars, snapshot = undefined) {
async function encodeEnvVarsAsset(vars, snapshot = undefined, maxSize = MAX_ENV_SIZE) {
if (!vars || typeof vars !== 'object') {
throw new Error('Expected variable values to be an object');
}
if (JSON.stringify(vars).length > MAX_ENV_SIZE) {
if (JSON.stringify(vars).length > maxSize) {
throw new Error('Asset exceeds the maximum size');
}
for (const [name, val] of Object.entries(vars)) {
Expand Down Expand Up @@ -1743,17 +1744,18 @@ async function encodeEnvVarsAsset(vars, snapshot = undefined) {
* @param {String|Buffer} snapshot.hash Snapshot hash. Can be a buffer or hex-encoded string.
* @param {String|Number} snapshot.updatedAt Snapshot creation time. Can be a string in a format
* supported by `Date.parse()` or a numeric timestamp.
* @param {Number} [maxSize=MAX_ENV_SIZE] Maximum allowed size of the resulting module.
* @returns {Promise<Buffer>} Module binary.
*/
async function createEnvVarsAssetModule(vars, snapshot = undefined) {
async function createEnvVarsAssetModule(vars, snapshot = undefined, maxSize = MAX_ENV_SIZE) {
let assetData;
if (Buffer.isBuffer(vars)) {
if (snapshot) {
throw new Error('Cannot set snapshot details in already encoded asset data');
}
assetData = vars;
} else {
assetData = await encodeEnvVarsAsset(vars, snapshot);
assetData = await encodeEnvVarsAsset(vars, snapshot, maxSize);
}

const assetModule = await createAssetModule(assetData, ENV_ASSET_NAME, {
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "binary-version-reader",
"version": "4.0.0",
"version": "4.0.1-rc.1",
"main": "main.js",
"license": "Apache-2.0",
"engines": {
Expand Down