Skip to content

dbal cleanup handler: check if a table or index exists before deleting it#834

Merged
DavidBadura merged 4 commits into3.19.xfrom
fix-dbal-cleanup-handler
Apr 1, 2026
Merged

dbal cleanup handler: check if a table or index exists before deleting it#834
DavidBadura merged 4 commits into3.19.xfrom
fix-dbal-cleanup-handler

Conversation

@DavidBadura
Copy link
Copy Markdown
Member

@DavidBadura DavidBadura commented Apr 1, 2026

No description provided.

@DavidBadura DavidBadura changed the title dbal cleanup handler: check if a table or index exists before deletin… dbal cleanup handler: check if a table or index exists before deleting it Apr 1, 2026
@DavidBadura DavidBadura added the bug Something isn't working label Apr 1, 2026
@DavidBadura DavidBadura requested a review from DanielBadura April 1, 2026 13:14
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Hello 👋

here is the most recent benchmark result:

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 5.175ms (±0.00%)   | 5.343ms (±0.00%)   | -3.15%    | 35.649mb        | 36.165mb   | -1.42%      |
| benchSave10000Events () | 331.877ms (±0.00%) | 355.303ms (±0.00%) | -6.59%    | 35.651mb        | 36.166mb   | -1.42%      |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.296s (±0.00%) | 3.310s (±0.00%) | -0.44%    | 47.557mb        | 47.557mb   | 0.00%       |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 83.350ms (±0.00%) | 82.567ms (±0.00%) | +0.95%    | 35.544mb        | 35.544mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.070ms (±0.00%)   | 1.077ms (±0.00%)   | -0.69%    | 35.044mb        | 35.044mb   | 0.00%       |
| benchLoad10000Events ()                | 62.320ms (±0.00%)  | 61.552ms (±0.00%)  | +1.25%    | 35.044mb        | 35.044mb   | 0.00%       |
| benchSave1Event ()                     | 1.275ms (±0.00%)   | 1.292ms (±0.00%)   | -1.26%    | 35.044mb        | 35.044mb   | 0.00%       |
| benchSave10000Events ()                | 217.933ms (±0.00%) | 218.247ms (±0.00%) | -0.14%    | 35.044mb        | 35.044mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.378s (±0.00%)    | 8.313s (±0.00%)    | +0.78%    | 35.044mb        | 35.044mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.204s (±0.00%)    | 5.184s (±0.00%)    | +0.38%    | 35.044mb        | 35.044mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                   | memory                                     |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 61.536ms (±0.00%) | 64.788ms (±0.00%) | -5.02%    | 35.049mb        | 35.049mb   | 0.00%       |
| benchLoad10000Events ()                | 1.065ms (±0.00%)  | 1.065ms (±0.00%)  | -0.04%    | 35.049mb        | 35.049mb   | 0.00%       |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

CommandToQueryBench
===================

+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
|                | time (kde mode)                                 | memory                                     |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
| subject        | Tag: <current>   | Tag: base        | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
| benchCreate () | 2.818ms (±0.00%) | 2.713ms (±0.00%) | +3.88%    | 5.100mb         | 5.100mb    | 0.00%       |
| benchUpdate () | 4.157ms (±0.00%) | 4.015ms (±0.00%) | +3.54%    | 4.931mb         | 4.931mb    | 0.00%       |
| benchBoth ()   | 6.753ms (±0.00%) | 6.895ms (±0.00%) | -2.06%    | 5.025mb         | 5.026mb    | -0.01%      |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.153ms (±0.00%)   | 1.138ms (±0.00%)   | +1.26%    | 35.206mb        | 35.206mb   | 0.00%       |
| benchLoad10000Events ()                | 70.045ms (±0.00%)  | 68.699ms (±0.00%)  | +1.96%    | 35.206mb        | 35.206mb   | 0.00%       |
| benchSave1Event ()                     | 1.325ms (±0.00%)   | 1.341ms (±0.00%)   | -1.22%    | 35.206mb        | 35.206mb   | 0.00%       |
| benchSave10000Events ()                | 283.299ms (±0.00%) | 285.215ms (±0.00%) | -0.67%    | 35.206mb        | 35.206mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.581s (±0.00%)    | 8.536s (±0.00%)    | +0.52%    | 35.206mb        | 35.206mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.399s (±0.00%)    | 5.378s (±0.00%)    | +0.40%    | 35.206mb        | 35.206mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.119ms (±0.00%)   | 1.117ms (±0.00%)   | +0.18%    | 35.584mb        | 35.584mb   | 0.00%       |
| benchLoad10000Events ()                | 99.549ms (±0.00%)  | 98.135ms (±0.00%)  | +1.44%    | 35.584mb        | 35.584mb   | 0.00%       |
| benchSave1Event ()                     | 1.864ms (±0.00%)   | 1.810ms (±0.00%)   | +2.98%    | 35.584mb        | 35.584mb   | 0.00%       |
| benchSave10000Events ()                | 249.209ms (±0.00%) | 247.011ms (±0.00%) | +0.89%    | 35.659mb        | 35.659mb   | 0.00%       |
| benchSave10000Aggregates ()            | 12.814s (±0.00%)   | 12.690s (±0.00%)   | +0.98%    | 35.585mb        | 35.585mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 9.569s (±0.00%)    | 9.603s (±0.00%)    | -0.36%    | 36.044mb        | 36.044mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura added this to the 3.19.0 milestone Apr 1, 2026
@DavidBadura DavidBadura merged commit bc80688 into 3.19.x Apr 1, 2026
40 of 41 checks passed
@DavidBadura DavidBadura deleted the fix-dbal-cleanup-handler branch April 1, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants