Skip to content

fix remove subscription with cleanup error#838

Open
DavidBadura wants to merge 1 commit into3.19.xfrom
fix-remove-subscription-with-cleanup-error
Open

fix remove subscription with cleanup error#838
DavidBadura wants to merge 1 commit into3.19.xfrom
fix-remove-subscription-with-cleanup-error

Conversation

@DavidBadura
Copy link
Copy Markdown
Member

No description provided.

@DavidBadura DavidBadura requested a review from DanielBadura April 4, 2026 06:36
@DavidBadura DavidBadura added the bug Something isn't working label Apr 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

Hello 👋

here is the most recent benchmark result:

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.905ms (±0.00%)   | 5.036ms (±0.00%)   | -2.60%    | 35.649mb        | 36.165mb   | -1.42%      |
| benchSave10000Events () | 321.107ms (±0.00%) | 320.085ms (±0.00%) | +0.32%    | 35.651mb        | 35.652mb   | -0.00%      |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 2.665s (±0.00%) | 2.644s (±0.00%) | +0.79%    | 47.557mb        | 47.557mb   | 0.00%       |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 73.118ms (±0.00%) | 73.781ms (±0.00%) | -0.90%    | 35.544mb        | 35.544mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 962.300μs (±0.00%) | 997.200μs (±0.00%) | -3.50%    | 35.044mb        | 35.044mb   | 0.00%       |
| benchLoad10000Events ()                | 55.961ms (±0.00%)  | 55.615ms (±0.00%)  | +0.62%    | 35.044mb        | 35.044mb   | 0.00%       |
| benchSave1Event ()                     | 1.100ms (±0.00%)   | 1.068ms (±0.00%)   | +3.01%    | 35.044mb        | 35.044mb   | 0.00%       |
| benchSave10000Events ()                | 209.856ms (±0.00%) | 208.828ms (±0.00%) | +0.49%    | 35.044mb        | 35.044mb   | 0.00%       |
| benchSave10000Aggregates ()            | 5.750s (±0.00%)    | 5.803s (±0.00%)    | -0.92%    | 35.044mb        | 35.044mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 3.821s (±0.00%)    | 3.824s (±0.00%)    | -0.08%    | 35.044mb        | 35.044mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 56.037ms (±0.00%)  | 56.464ms (±0.00%)  | -0.76%    | 35.049mb        | 35.049mb   | 0.00%       |
| benchLoad10000Events ()                | 947.100μs (±0.00%) | 989.600μs (±0.00%) | -4.29%    | 35.049mb        | 35.049mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

CommandToQueryBench
===================

+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
|                | time (kde mode)                                 | memory                                     |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
| subject        | Tag: <current>   | Tag: base        | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
| benchCreate () | 2.425ms (±0.00%) | 2.463ms (±0.00%) | -1.53%    | 5.100mb         | 5.100mb    | 0.00%       |
| benchUpdate () | 3.570ms (±0.00%) | 3.665ms (±0.00%) | -2.60%    | 4.931mb         | 4.931mb    | 0.00%       |
| benchBoth ()   | 5.860ms (±0.00%) | 5.851ms (±0.00%) | +0.15%    | 5.026mb         | 5.026mb    | 0.00%       |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.014ms (±0.00%)   | 1.047ms (±0.00%)   | -3.22%    | 35.206mb        | 35.206mb   | 0.00%       |
| benchLoad10000Events ()                | 64.635ms (±0.00%)  | 61.783ms (±0.00%)  | +4.62%    | 35.206mb        | 35.206mb   | 0.00%       |
| benchSave1Event ()                     | 1.065ms (±0.00%)   | 1.081ms (±0.00%)   | -1.46%    | 35.206mb        | 35.206mb   | 0.00%       |
| benchSave10000Events ()                | 268.107ms (±0.00%) | 268.605ms (±0.00%) | -0.19%    | 35.206mb        | 35.206mb   | 0.00%       |
| benchSave10000Aggregates ()            | 6.021s (±0.00%)    | 6.018s (±0.00%)    | +0.05%    | 35.206mb        | 35.206mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 3.978s (±0.00%)    | 3.985s (±0.00%)    | -0.16%    | 35.206mb        | 35.206mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.019ms (±0.00%)   | 1.013ms (±0.00%)   | +0.63%    | 35.584mb        | 35.584mb   | 0.00%       |
| benchLoad10000Events ()                | 86.107ms (±0.00%)  | 86.882ms (±0.00%)  | -0.89%    | 35.585mb        | 35.585mb   | 0.00%       |
| benchSave1Event ()                     | 1.559ms (±0.00%)   | 1.560ms (±0.00%)   | -0.09%    | 35.584mb        | 35.584mb   | 0.00%       |
| benchSave10000Events ()                | 234.492ms (±0.00%) | 234.229ms (±0.00%) | +0.11%    | 35.659mb        | 35.659mb   | 0.00%       |
| benchSave10000Aggregates ()            | 9.176s (±0.00%)    | 9.262s (±0.00%)    | -0.93%    | 35.585mb        | 35.585mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 7.153s (±0.00%)    | 7.209s (±0.00%)    | -0.77%    | 36.044mb        | 36.044mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura added this to the 3.19.1 milestone Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant