Skip to content

Fixing issues. #253

Merged
daveshanley merged 2 commits intomainfrom
fixy
Mar 15, 2026
Merged

Fixing issues. #253
daveshanley merged 2 commits intomainfrom
fixy

Conversation

@daveshanley
Copy link
Member

More issues across the stack are being cleaned up.

there have been a lot more nil checks added, but this really goes deep, so I can close out this issue.
@daveshanley daveshanley merged commit 1151bc5 into main Mar 15, 2026
2 checks passed
@codecov
Copy link

codecov bot commented Mar 15, 2026

Codecov Report

❌ Patch coverage is 98.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.94%. Comparing base (881f8cb) to head (b529f4b).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
errors/spec_line_col.go 90.69% 4 Missing ⚠️
responses/validate_body.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
- Coverage   97.98%   97.94%   -0.04%     
==========================================
  Files          63       64       +1     
  Lines        6395     6525     +130     
==========================================
+ Hits         6266     6391     +125     
- Misses        128      133       +5     
  Partials        1        1              
Flag Coverage Δ
unittests 97.94% <98.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant