Add axe-core support in ng-unit-testing library for accessibility testing utilities#130
Open
Add axe-core support in ng-unit-testing library for accessibility testing utilities#130
axe-core support in ng-unit-testing library for accessibility testing utilities#130Conversation
added 2 commits
April 24, 2026 17:34
david-d-k
changed the title
axe-core support in ng-unit-testing library for accessibility testing utilities
glenstaes
requested changes
Apr 24, 2026
| <div class="ppw-loader"> | ||
| @if (loading()) { | ||
| <mat-progress-bar mode="indeterminate" type="progressbar"></mat-progress-bar> | ||
| <mat-progress-bar mode="indeterminate" type="progressbar" aria-label="Loading"></mat-progress-bar> |
Member
There was a problem hiding this comment.
Doesn't this need to be translatable?
| }) | ||
|
|
||
| it('should have no accessibility violations in its default state', async () => { | ||
| const fixture = TestBed.createComponent(ExpandableCardDemoComponent) |
Member
There was a problem hiding this comment.
This is a recurring pattern. Maybe it's an idea to just have a single function to call? 'verifyA11y(ExpandableCardDemoComponent)' or something alike.
| (click)="toggleExpand(record.initialRecord); $event.stopPropagation()" | ||
| class="ppw-table-expand-toggle-button" | ||
| [class.ppw-table-expand-toggle-button--expanded]="isExpanded(record.initialRecord)" | ||
| [aria-label]="isExpanded(record.initialRecord) ? 'Collapse row' : 'Expand row'" |
MarkCuypersPpw
requested changes
Apr 27, 2026
Contributor
MarkCuypersPpw
left a comment
MarkCuypersPpw
left a comment
There was a problem hiding this comment.
I suggest that the 2nd commit is split up in 2 commits:
- 1 that fixes the A11y issues in our components.
- 1 that adds the new unit tests to prevent A11y issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ppwcode/ng-unit-testing.