pmrep.py: add units to CSV header output#2528
Open
orasagar wants to merge 2 commits intoperformancecopilot:mainfrom
Open
pmrep.py: add units to CSV header output#2528orasagar wants to merge 2 commits intoperformancecopilot:mainfrom
orasagar wants to merge 2 commits intoperformancecopilot:mainfrom
Conversation
Previously, pmrep displayed units in stdout but omitted them when exporting data with the CSV option. This change updates the CSV header to include units, aligning CSV exports with the stdout format.
Member
|
QA test updates/additions please. |
Adjust expected QA CSV headers to include count and Kbyte units, matching updated pmrep output formatting.
natoscott
requested changes
Mar 18, 2026
Member
natoscott
left a comment
natoscott
left a comment
There was a problem hiding this comment.
Needs some QA - updates to existing and/or new tests please. Possibly a man page update too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, pmrep displayed units in stdout but omitted them when exporting data with the CSV option. This change updates the CSV header to include units, aligning CSV exports with the stdout format.