Skip to content

Use quoteattr for attribute serialization (Python 3.14) #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tobias-Fischer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use quoteattr for attribute serialization (Python 3.14) #511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions roboticstoolbox/tools/xacro/xmlutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
# Maintainer: Morgan Quigley <morgan@osrfoundation.org>

import xml.dom.minidom
from xml.sax.saxutils import quoteattr


def first_child_element(elt):
Expand Down Expand Up @@ -120,9 +121,7 @@ def fixed_writexml(self, writer, indent="", addindent="", newl=""): # pragma:
a_names = sorted(attrs.keys())

for a_name in a_names:
writer.write(" %s=\"" % a_name)
xml.dom.minidom._write_data(writer, attrs[a_name].value)
writer.write("\"")
writer.write(" %s=%s" % (a_name, quoteattr(attrs[a_name].value)))
if self.childNodes:
if len(self.childNodes) == 1 \
and self.childNodes[0].nodeType == xml.dom.minidom.Node.TEXT_NODE:
Expand Down