feat: added support cross app secret referencing#16
Merged
Conversation
… cross-application references. Updated the resolve_secret_reference function to handle references across different applications, improving flexibility in secret management.
rohan-chaturvedi
previously approved these changes
Apr 6, 2025
Member
rohan-chaturvedi
left a comment
There was a problem hiding this comment.
LGTM, everything working as expected. Needs a version bump though
rohan-chaturvedi
approved these changes
Apr 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for secret referencing across applications.
Additional changes:
@rohan-chaturvedi you may use the following script to access secrets:
PHASE_SERVICE_TOKENapp_id