Skip to content

Remove doctrine annotations#186

Open
mgiraud wants to merge 5 commits intophp-translation:masterfrom
mgiraud:remove-doctrine-annotations
Open

Remove doctrine annotations#186
mgiraud wants to merge 5 commits intophp-translation:masterfrom
mgiraud:remove-doctrine-annotations

Conversation

@mgiraud
Copy link

@mgiraud mgiraud commented Mar 9, 2026

Closes #181
Closes #176

At first it thought about keeping the annotation classes, but they become useless.

Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no experience with phpstan/phpdoc-parser, but I see test sare happy with this change, so it looks good to me.

Could you also fix failed SA?

@bocharsky-bw
Copy link
Member

Hm, I'm thinking about doing a minor release for this... but if we completely drop annotation files like ‎src/Annotation/Desc.php - it will be still a BC break, right? I wonder if we should revert removing them and keep them deprecated for a while in this project, along with the doctrine/annotations package? I suppose if users will not stop using them in their projects - there should not be deprecation warnings for them, right? WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package doctrine/annotations is abandoned, you should avoid using it. No replacement was suggested.

2 participants