日本語訳の存在しない新規翻訳ページ（NoDiscard, StreamBucket）#338
Open
KentarouTakeda wants to merge 3 commits intophp:masterfrom
Open
日本語訳の存在しない新規翻訳ページ（NoDiscard, StreamBucket）#338KentarouTakeda wants to merge 3 commits intophp:masterfrom
KentarouTakeda wants to merge 3 commits intophp:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
日本語訳が未整備だった新規ドキュメント（NoDiscard 属性と StreamBucket クラス）を追加し、定義済み属性の一覧に NoDiscard を組み込むPRです。
Changes:
StreamBucketクラスのリファレンスページを新規追加NoDiscard属性ページおよびNoDiscard::__constructを新規追加- 定義済み属性一覧（
attributes.xml）にNoDiscardを追加し、EN-Revision を更新
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| reference/stream/streambucket.xml | StreamBucket クラスの新規リファレンスページを追加 |
| language/predefined/attributes/nodiscard.xml | NoDiscard 属性の新規リファレンスページを追加 |
| language/predefined/attributes/nodiscard/construct.xml | NoDiscard::__construct の新規リファレンスページを追加 |
| language/predefined/attributes.xml | 定義済み属性一覧に NoDiscard を追加、EN-Revision を更新 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
php/doc-en@a7be7e9abb (#5395) の修正を反映。
takaram
reviewed
Mar 1, 2026
| <section xml:id="nodiscard.intro"> | ||
| &reftitle.intro; | ||
| <simpara> | ||
| このアトリビュートは、関数やメソッドの戻り値を破棄すべきでないことを示すために使います。 |
Contributor
There was a problem hiding this comment.
discardの訳語として「破棄する」が使われていますが、destructの意味にも取れてしまい、やや誤解を招くかもしれないと感じています。
「捨てる」「無視する」などが個人的にはしっくりくるように感じます。いかがでしょう？
Collaborator
Author
There was a problem hiding this comment.
5136772: ありがとうございます！仰るとおりですね。「無視」としました。
| </section> | ||
|
|
||
| <section> | ||
| &reftitle.examples; |
Contributor
There was a problem hiding this comment.
コード例のコメントが英語のままですが、他のページはコメントまで日本語訳されていることが多そうです。
- 「破棄する」→「無視する」に変更（レビュー指摘対応） - コード例内の英語コメントを日本語に翻訳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NoDiscard
StreamBucket