Skip to content

Force reload in frankenphp service configuration#2281

Open
kitro wants to merge 2 commits intophp:mainfrom
kitro:patch-1
Open

Force reload in frankenphp service configuration#2281
kitro wants to merge 2 commits intophp:mainfrom
kitro:patch-1

Conversation

@kitro
Copy link

@kitro kitro commented Mar 13, 2026

@henderkes This resolve the symlink issue for the symlink deployment strategy.
alpine already have the force flag.

@kitro kitro marked this pull request as ready for review March 13, 2026 22:20
@henderkes
Copy link
Contributor

I'm not sure if this should be made the default. I've tried to mirror Caddy's service definitions as closely as possible.

@henderkes
Copy link
Contributor

@dunglas @alexandre-daubois thoughts on this?

@kitro you can use "frankenphp reload" instead of systemctl reload frankenphp, by the way. The command really only sends a http request to the admin API, so it doesn't have to happen initiated by systemd.

@kitro
Copy link
Author

kitro commented Mar 14, 2026

@henderkes Yes, It can be used the frankenphp reload -c /etc/frankenphp/Caddyfile --force.
As you see the issue of symlink It's been happening a lot lately, as many people using the symbolic link deployment and the service manager to reload.

From frankenphp perspective used as drop-in-replacement of fpm I think is good to make it default.

@alexandre-daubois
Copy link
Member

This feels weird because --force wasn't introduce for this purpose (see caddyserver/dist#84).

Maybe we should look into Caddy's resolve_root_symlink option?

@henderkes
Copy link
Contributor

This feels weird because --force wasn't introduce for this purpose (see caddyserver/dist#84).

Maybe we should look into Caddy's resolve_root_symlink option?

There's nothing to really change there. Realpath prevents non-worker script changes from being picked up immediately and workers need to be restarted anyway.

@alexandre-daubois
Copy link
Member

Well maybe it makes sense to add --force after all. We already have it for Alpine, so it would sync everything on this side.

kitro added 2 commits March 16, 2026 05:55
Signed-off-by: Nordine <5256921+kitro@users.noreply.github.com>
@kitro
Copy link
Author

kitro commented Mar 16, 2026

I think is good to merge.
Thanks!

Copy link
Contributor

@henderkes henderkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, no objections from my side then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants