ext/session: code cleanup and minor refactoring#21467
Open
thg2k wants to merge 6 commits intophp:masterfrom
Open
ext/session: code cleanup and minor refactoring#21467thg2k wants to merge 6 commits intophp:masterfrom
thg2k wants to merge 6 commits intophp:masterfrom
Conversation
Member
|
CI is failling but I'm in favour of those consistency fixes. I was recently again looking at setting up clang format and clang tidy on an individual extension basis. |
Contributor
Author
My bad, I redid the changes from a local branch and did not test it. I'll fix it right away! |
thg2k
force-pushed
the
pr/session_cleanup_1
branch
from
9d133e0 to
355d08a
Compare
Contributor
Author
|
@Girgias CI is green, please let me know if you manage to review it, in particular the changes to OnUpdateSidBits and OnUpdateSessionGcProbability. I find the strategy to return early on failure and leave the success case for last to be much more readable, if you are in favor I have more like that to submit. Also how do you stand on the space after cast? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.