Skip to content

Add mutation testing with Infection #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asgrim wants to merge 1 commit into
base: 1.4.x
Choose a base branch
from
Open

Add mutation testing with Infection #553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/continuous-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,22 @@ jobs:
- name: Run phpstan
run: vendor/bin/phpstan

mutation-testing:
runs-on: ubuntu-latest
steps:
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: 8.4
extensions: intl, sodium, zip
tools: infection
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- uses: actions/checkout@v6
- uses: ramsey/composer-install@v3
- name: Run infection
run: sudo infection --min-msi=68 --min-covered-msi=68 --threads=4 --show-mutations=max --no-progress
Copy link
Contributor

@theofidry theofidry Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • is sudo necessary here?!
  • any reason to use --threads=4 instead of --threads=max?

Copy link
Contributor Author

@asgrim asgrim Mar 18, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • is sudo necessary here?!

yep, the tests require it (because I can't non-interactively sudo)

  • any reason to use --threads=4 instead of --threads=max?

nope :) will update


build-assets:
needs:
- unit-tests
Expand Down
11 changes: 11 additions & 0 deletions infection.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"$schema": "https://raw.githubusercontent.com/infection/infection/0.32.6/resources/schema.json",
Copy link
Contributor

@theofidry theofidry Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so what's the workflow to run it locally and not the CI when you're developing?

Copy link
Contributor Author

@asgrim asgrim Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the phar, as per the docs; I suppose that should be documented 😁

"source": {
"directories": [
"src"
]
},
"mutators": {
"@default": true
Copy link
Contributor

@theofidry theofidry Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as an app, maybe it's already disabled by default, there is the public -> protected/private mutator that can be disabled

}
}
Loading