-
Notifications
You must be signed in to change notification settings - Fork 554
Fix seemingly same type reports as invalid/incompatible. #5094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
VincentLanglet
merged 6 commits into
phpstan:2.1.x
from
VincentLanglet:create-pull-request/patch-v6x5b0k
Mar 1, 2026
+140
−5
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
63ad626
Fix false positive invariance check for template types with same iden…
github-actions[bot] 122b06b
Rework
VincentLanglet 3845338
Simplify
VincentLanglet e4b026a
Add test
VincentLanglet 4692e26
Add non regression test
VincentLanglet f29c09c
Fix build on 7.4
VincentLanglet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| <?php // lint >= 8.0 | ||
|
|
||
| declare(strict_types = 1); | ||
|
|
||
| namespace Bug13440; | ||
|
|
||
| use Closure; | ||
|
|
||
| /** @template T */ | ||
| interface Foo {} | ||
|
|
||
| /** | ||
| * @template TVal | ||
| * @template TReturn | ||
| */ | ||
| class Box | ||
| { | ||
| /** | ||
| * @param TVal $val | ||
| * @param Closure(Foo<TVal>): TReturn $cb | ||
| */ | ||
| public function __construct( | ||
| private mixed $val, | ||
| private Closure $cb, | ||
| ) { | ||
| } | ||
|
|
||
| /** | ||
| * @template TNewReturn | ||
| * @param Closure(Foo<TVal>): TNewReturn $cb | ||
| * @return self<TVal, TNewReturn> | ||
| */ | ||
| public function test(Closure $cb): self | ||
| { | ||
| return new self($this->val, $cb); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * @template TVal | ||
| * @template TReturn | ||
| */ | ||
| class Box2 | ||
| { | ||
| /** | ||
| * @param TVal $val | ||
| * @param callable(Foo<TVal>): TReturn $cb | ||
| */ | ||
| public function __construct( | ||
| private mixed $val, | ||
| private $cb, | ||
| ) { | ||
| } | ||
|
|
||
| /** | ||
| * @template TNewReturn | ||
| * @param callable(Foo<TVal>): TNewReturn $cb | ||
| * @return self<TVal, TNewReturn> | ||
| */ | ||
| public function test($cb): self | ||
| { | ||
| return new self($this->val, $cb); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| <?php // lint >= 8.1 | ||
|
|
||
| namespace Bug12688; | ||
|
|
||
| /** | ||
| * @template T = mixed | ||
| */ | ||
| interface I {} | ||
|
|
||
| /** | ||
| * @implements I<mixed> | ||
| */ | ||
| enum E implements I | ||
| { | ||
| case E; | ||
| } | ||
|
|
||
| /** | ||
| * @template T | ||
| */ | ||
| final class TemplateWithoutDefaultWorks | ||
| { | ||
| /** | ||
| * @var I<T> | ||
| */ | ||
| public readonly I $i; | ||
|
|
||
| /** | ||
| * @param I<T> $i | ||
| */ | ||
| public function __construct(I $i = E::E) | ||
| { | ||
| $this->i = $i; | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * @template T = mixed | ||
| */ | ||
| final class TemplateWithDefaultDoesNotWork | ||
| { | ||
| /** | ||
| * @var I<T> | ||
| */ | ||
| public readonly I $i; | ||
|
|
||
| /** | ||
| * @param I<T> $i | ||
| */ | ||
| public function __construct(I $i = E::E) | ||
| { | ||
| $this->i = $i; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need another test for callable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added