AcceptsResult: cache Yes/No/Maybe#5095
Merged
VincentLanglet merged 1 commit intophpstan:2.1.xfrom Feb 28, 2026
Merged
Conversation
Collaborator
|
You've opened the pull request against the latest branch 2.2.x. PHPStan 2.2 is not going to be released for months. If your code is relevant on 2.1.x and you want it to be released sooner, please rebase your pull request and change its target to 2.1.x. |
staabm
reviewed
Feb 28, 2026
| callable $callback, | ||
| ): self | ||
| { | ||
| $results = []; |
Contributor
There was a problem hiding this comment.
Would be nice phpstan would detect local variables which are only written but never read
Member
There was a problem hiding this comment.
There are feature requests for that. It'd be very easy to implement too I think. We'd need virtual expr nodes like PropertyInitializationExpr to track things in scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found some useless variable in lazyMaxMin, and then I found that you cached Yes/no/maybe in SuperTypeOf but not AcceptResult @staabm. I think we can do the same.