Skip to content

fix(viewer): Unneeded manual internal link; Fix target is in LaTeX#215

Merged
StevenClontz merged 2 commits intopi-base:mainfrom
yhx-12243:unneeded-internal-link
Mar 23, 2026
Merged

fix(viewer): Unneeded manual internal link; Fix target is in LaTeX#215
StevenClontz merged 2 commits intopi-base:mainfrom
yhx-12243:unneeded-internal-link

Conversation

@yhx-12243
Copy link
Contributor

Svelte has automatically internal link mechanism, so the manual implementation is not necessary and it is also wrong: When user click internal link just in LaTeX, it will goto undefined. So we simply delete it and it works well.

link.addEventListener('click', e => {
e.preventDefault()
goto((e.target as HTMLAnchorElement).href)
})

e.target is not necessary an <a>, it may deep inside a KaTeX node.

@yhx-12243
Copy link
Contributor Author

yhx-12243 commented Mar 18, 2026

Anyone reviewing this, as well as #207 and #240? These are simple PR's and can be quickly merged imo. @StevenClontz

Copy link
Member

@StevenClontz StevenClontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StevenClontz StevenClontz merged commit b94120f into pi-base:main Mar 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants