fix(viewer): Unneeded manual internal link; Fix target is in LaTeX#215
Merged
StevenClontz merged 2 commits intopi-base:mainfrom Mar 23, 2026
Merged
fix(viewer): Unneeded manual internal link; Fix target is in LaTeX#215StevenClontz merged 2 commits intopi-base:mainfrom
StevenClontz merged 2 commits intopi-base:mainfrom
Conversation
Contributor
Author
|
Anyone reviewing this, as well as #207 and #240? These are simple PR's and can be quickly merged imo. @StevenClontz |
StevenClontz
approved these changes
Mar 23, 2026
Member
StevenClontz
left a comment
There was a problem hiding this comment.
looks good at https://pr215-local.topology.pages.dev/theorems/T000363 -- merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Svelte has automatically internal link mechanism, so the manual implementation is not necessary and it is also wrong: When user click internal link just in LaTeX, it will goto undefined. So we simply delete it and it works well.
web/packages/viewer/src/components/Shared/Typeset.svelte
Lines 51 to 54 in c571c93
e.targetis not necessary an<a>, it may deep inside a KaTeX node.