planner: update the default value of tidb_ignore_inlist_plan_digest to True (#22516) #22694
+3
−3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -3475,11 +3475,11 @@ For a system upgraded to v5.0 from an earlier version, if you have not modified | |||||
| - Persists to cluster: Yes | ||||||
| - Applies to hint [SET_VAR](/optimizer-hints.md#set_varvar_namevar_value): No | ||||||
| - Type: Boolean | ||||||
| - Default value: `ON`. Before v8.5.6, the default value is `OFF`. | ||||||
| - This variable controls whether TiDB ignores the element differences in the `IN` list across different queries when generating Plan Digests. | ||||||
|
|
||||||
| - When it is the default value `ON`, TiDB ignores the element differences (including the difference in the number of elements) in the `IN` list and uses `...` to replace elements in the `IN` list in Plan Digests. In this case, TiDB generates the same Plan Digests for `IN` queries of the same type. | ||||||
| - When it is set to `OFF`, TiDB does not ignore the element differences (including the difference in the number of elements) in the `IN` list when generating Plan Digests. The element differences in the `IN` list result in different Plan Digests. | ||||||
|
Contributor
There was a problem hiding this comment. For consistency and conciseness, consider simplifying the phrasing here as well (Style Guide Rule 24).
Suggested change
References
|
||||||
|
|
||||||
| ### tidb_index_join_batch_size | ||||||
|
|
||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrasing 'When it is the default value ON' is wordy. Consider using a more concise structure to improve readability, following the principle of avoiding unnecessary words (Style Guide Rule 24).
References