chore: roll to Playwright v1.57.0#578
Merged
mxschmitt merged 2 commits intoplaywright-community:mainfrom Jan 16, 2026
Merged
Conversation
Fix playwright submodule commit Rerun gofumpt Change ConsoleMessages to use newConsoleMessage() to properly deserialize event objects Add test coverage Update page_test.go Fix failing end-to-end test Update README.md Fix README Update README.md
Open
Collaborator
|
Hey! Thanks for the contribution! Do you think you would be able to unflake the 3 red status checks? Thanks! |
Contributor
Author
|
@mxschmitt Looking good now! |
mxschmitt
approved these changes
Jan 16, 2026
| 1. Fix merge conflicts if any, otherwise ignore this step. Once you are happy you can commit the changes `cd playwright; git commit -am "apply patch" && cd ..` | ||
| 1. Regenerate a new patch `bash scripts/update-patch.sh` | ||
| 1. Generate go code `go generate ./...` | ||
| 2. Download current version of Playwright driver `go run scripts/install-browsers/main.go` |
Collaborator
There was a problem hiding this comment.
Please revert, GitHub does automatically add auto increment numbers when using 1..
Contributor
Author
There was a problem hiding this comment.
This change was actually to make it more readable for AI Agents. My agent had trouble understanding the order of these steps (and sometimes skipped ones altogether) and I believe it was because all the steps were marked as 1.
I thought this change would be useful without causing any actual issues, but I can revert if you still feel like I should. Just let me know either way
|
When might this version roll be released? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't want to make this PR without noting that I used Claude Opus 4.5 and Sonnet 4.5 to assist throughout this upgrade. I'm a developer with over a decade of experience and I use these tools extensively in my day-to-day work; no edits were made without my review. It helped me knock this out in a weekend instead of weeks. Plus, I figured an AI-coded
playwright-gocompatible with v1.57.0 is better than nothing at all.I have validated that all test cases pass locally and confirmed that it works both launching locally and connecting via WebSocket in my own project. Even if there are some bugs (which I'm sure there are), I think this is good enough to get this project to 100% for v1.57.0. A summary of these changes (generated by Claude) is below
Key Changes
Protocol Compliance
Architecture Updates
New API Features
Page.ConsoleMessages()andPage.Requests()methods for retrieving accumulated page eventsConsoleMessage.Worker()support for console messages originating from web workersLocator.Describe()andLocator.Description()for custom locator descriptions in error messagesStepsparameter to click/hover/drag methods for interpolated mousemove eventsBug Fixes
selectors.gowhen registering selectors concurrently with context creationTesting