Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a few new APIs I needed for the Tauri SDK, but I believe the new features should be useful for Rust users as well.
First,
LeasedConnectionis now a concrete type instead of a trait. This makes it much easier for users to use and store connections in structs. I've also changed the implementation ofreader()andwriter()on pools to allowLeasedConnectionto be+ 'static(previously it would reference the database from which the connection has been obtained). This isn't less efficient in this case since the pool is already anArcwe can cheaply clone, but makesLeasedConnections easier to store in other structs.Additionally, this adds the
watch_all_updatesstream emitting a set of tables that have been written to since the last poll. This is necessary to forward updates to JavaScript, where we need to update listeners without knowing which tables they're interested in.I've also added an internal APIs to get the internal sync stream status from the core extension out of the public sync status. We don't want to expose that to end users, but it makes it easier to forward sync status updates to the JavaScript SDK.
Finally, this updates
rusqliteand prepares a 0.0.5 release.