Skip creating ps_crud entries when clearing raw tables#169
Merged
Conversation
rkistner
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes happening as part of
powersync_clear()should not count asps_crudentries. For JSON-based tables, we're able to do this by deleting from the underlying table instead of the view.For raw tables, we'd run the
clearstatement configured on the table. This is problematic since raw tables would typically have triggers recording the delete inps_crud, and we have no separate data table to side-step that trigger.As a cheap workaround, this makes
powersync_in_sync_operation()true while clearing raw tables. That disarms theps_crudvtab, giving us the behavior we want.Originally reported on the Kotlin SDK: powersync-ja/powersync-kotlin#335