Skip to content

Prepare 1.5.0#84

Merged
nilsbehlen merged 9 commits intomasterfrom
prepare-1.5.0
Mar 26, 2026
Merged

Prepare 1.5.0#84
nilsbehlen merged 9 commits intomasterfrom
prepare-1.5.0

Conversation

@nilsbehlen
Copy link
Copy Markdown
Member

No description provided.

@nilsbehlen nilsbehlen requested a review from Copilot March 5, 2026 13:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Prepares the privacyidea-java-client for the 1.5.0 release by extending challenge/passkey handling, adjusting client-mode based logic, improving async response body handling/logging, and bumping the Maven version.

Changes:

  • Update PIResponse challenge helpers (pushAvailable, otpMessage, hasChallenges) and customize Gson deserialization for Challenge.
  • Extend JSONParser to recognize passkey challenges inside multi_challenge.
  • Refactor OkHttp async response consumption to close ResponseBody and include HTTP status in logs; bump project version to 1.5.0.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File Description
src/main/java/org/privacyidea/PIResponse.java Adds challenge helpers and new filtering logic; introduces a custom Gson deserializer for Challenge.
src/main/java/org/privacyidea/JSONParser.java Adds handling for passkey challenges found in the multi_challenge array.
src/main/java/org/privacyidea/AsyncRequestCallable.java Ensures response bodies are closed and adjusts logging behavior/format.
pom.xml Bumps artifact version to 1.5.0 and changes test execution configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pom.xml Outdated
Comment on lines 21 to 22
<skipTests>true</skipTests>
</configuration>
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting Surefire’s <skipTests> to true disables unit tests for all builds, which makes it easy to ship regressions (especially for a release bump). If the intent is only to speed up local packaging, consider removing this change or gating it behind a Maven profile / CI property instead of committing it as the default.

Copilot uses AI. Check for mistakes.
nilsbehlen and others added 6 commits March 26, 2026 08:54
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@nilsbehlen nilsbehlen merged commit dd6ad00 into master Mar 26, 2026
1 check passed
@nilsbehlen nilsbehlen deleted the prepare-1.5.0 branch March 26, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants