Skip to content

(WIP) Add ExtendingTraceTranslator.#370

Open
ztangent wants to merge 1 commit intomasterfrom
20210212_ztangent_extending
Open

(WIP) Add ExtendingTraceTranslator.#370
ztangent wants to merge 1 commit intomasterfrom
20210212_ztangent_extending

Conversation

@ztangent
Copy link
Copy Markdown
Member

Addresses #313 by adding a more flexible variant of SimpleExtendingTraceTranslator: ExtendingTraceTranslator accepts a bijective trace transform that remaps the choices sampled by the forward proposal distribution, before merging those choices into the extended model via update.

Before I move forward with adding documentation and test cases, I'm wondering if perhaps this should just replace the existing SimpleExtendingTraceTranslator? This does everything that SimpleExtendingTraceTranslator does, and I don't think it adds much of a performance overhead to have the if-else clause in ExtendingTraceTranslator that checks whether a trace transform needs to be applied. For backwards compatibility, I could even make SimpleExtendingTraceTranslator a constructor alias for an ExtendingTraceTranslator with the bijection filled in with nothing.

@ztangent ztangent requested a review from marcoct February 13, 2021 03:06
@ztangent
Copy link
Copy Markdown
Member Author

ztangent commented Apr 2, 2021

This work is due to be superseded by the implementations of ExtendingTraceTranslator and UpdatingTraceTranslator in:
https://github.com/probcomp/GenParticleFilters.jl/blob/3394832987e43d4214bddf49fcdccbf4098c7c18/src/translate.jl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant