(feat) Unify Readiness Logic for Auto and Manual Promotion#1666
Merged
gianlucam76 merged 1 commit intoprojectsveltos:mainfrom Mar 26, 2026
Merged
(feat) Unify Readiness Logic for Auto and Manual Promotion#1666gianlucam76 merged 1 commit intoprojectsveltos:mainfrom
gianlucam76 merged 1 commit intoprojectsveltos:mainfrom
Conversation
This PR moves the `Delay`, `PreHealthCheckDeployment`, and `PostDelayHealthChecks` logic into a shared reconciliation path. Whether a user chooses `Auto` or `Manual` mode, Sveltos will now perform the same sequence of validation steps before the stage is considered "ready." - **Manual promotion** shouldn't mean "blind promotion." By bringing these fields to manual mode, operators get: - Guardrails: Sveltos prevents a manual promotion from being triggered if health checks are failing. - Consistency: The same validation tests used in Auto mode can be used for sensitive production environments (Manual). - Reduced Human Error: Automatically deploying validation Jobs before asking for human approval ensures the reviewer has the data they need to make a decision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the
Delay,PreHealthCheckDeployment, andPostDelayHealthCheckslogic into a shared reconciliation path. Whether a user choosesAutoorManualmode, Sveltos will now perform the same sequence of validation steps before the stage is considered "ready."Manual promotion shouldn't mean "blind promotion." By bringing these fields to manual mode, operators get: