OM2: Discontinue OM Proto; specify PrometheusProto#2836
OM2: Discontinue OM Proto; specify PrometheusProto#2836
Conversation
bwplotka
force-pushed
the
bwplotka/om-proto
branch
4 times, most recently
from
94f1cc9 to
40185d0
Compare
krajorama
left a comment
krajorama
left a comment
There was a problem hiding this comment.
LGTM, let's see dev summit response
bwplotka
changed the title
Signed-off-by: bwplotka <bwplotka@gmail.com>
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
bwplotka/om-proto
branch
from
1c3163d to
a19a068
Compare
|
|
||
| ### Basic info | ||
|
|
||
| | Aspect | Description | |
There was a problem hiding this comment.
FYI: Taken from historical, yet still up-to-date Matt P. document https://docs.google.com/document/d/1ZjyKiKxZV83VI9ZKAXRGKaUKK2BIWCT7oiGBKDBpjEY/edit?tab=t.0#heading=h.enginc5vuf3z
Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
bwplotka/om-proto
branch
from
22e3764 to
d7fbfc6
Compare
|
This direction was approved on dev-summit |
|
LGTM for the protobuf part you asked me to have a look at. |
| ### Versioning | ||
|
|
||
| Earlier versions of Prometheus supported an exposition format based on [Protocol Buffers](https://developers.google.com/protocol-buffers/) (aka Protobuf) in addition to the current text-based format. With Prometheus 2.0, the Protobuf format was marked as deprecated and Prometheus stopped ingesting samples from said exposition format. | ||
| At the moment Prometheus protobuf is stable, but explicitly unversioned to lean towards the backward and forward compatibility factor. |
There was a problem hiding this comment.
What does "lean towards the backward and forward compatibility factor" mean?
There was a problem hiding this comment.
it means "lean on protobuf backward and forward compatibility logic". I simplified to
At the moment Prometheus protobuf is stable, but explicitly unversioned. Instead, it follows Prometheus versioning as a reference.
WDYT?
Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
bwplotka/om-proto
branch
from
21d7a81 to
8403858
Compare
|
Thanks for the detailed review. All should be addressed! I improved and added missing table for OpenMetrics for consistency. Added |
bwplotka
force-pushed
the
bwplotka/om-proto
branch
2 times, most recently
from
943e1b6 to
89f2d81
Compare
bwplotka
force-pushed
the
bwplotka/om-proto
branch
from
89f2d81 to
3c45e63
Compare
Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
bwplotka/om-proto
branch
from
3c45e63 to
1aefc37
Compare
7 participants
Fixes prometheus/OpenMetrics#296
This proposes:
Proposed this to be a discussion on DevSummit https://docs.google.com/document/d/1uurQCi5iVufhYHGlBZ8mJMK_freDFKPG0iYBQqJ9fvA/edit?tab=t.0#bookmark=id.8x3p3zrx8mfu