Merged
Conversation
carlos-granados
added
the
performance-check
carlos-granados
force-pushed
the
restore-ci-benchmark
branch
from
9dd747b to
11643c0
Compare
carlos-granados
added
performance-check
carlos-granados
force-pushed
the
restore-ci-benchmark
branch
from
11643c0 to
cd91387
Compare
carlos-granados
added
performance-check
carlos-granados
force-pushed
the
restore-ci-benchmark
branch
from
cd91387 to
d0f0b2b
Compare
carlos-granados
added
performance-check
carlos-granados
force-pushed
the
restore-ci-benchmark
branch
from
d0f0b2b to
4d600dd
Compare
carlos-granados
added
performance-check
carlos-granados
force-pushed
the
restore-ci-benchmark
branch
from
4d600dd to
3b81976
Compare
carlos-granados
added
performance-check
carlos-granados
force-pushed
the
restore-ci-benchmark
branch
from
3b81976 to
d30159e
Compare
carlos-granados
added
performance-check
carlos-granados
force-pushed
the
restore-ci-benchmark
branch
from
d30159e to
c117280
Compare
carlos-granados
added
performance-check
carlos-granados
force-pushed
the
restore-ci-benchmark
branch
from
c117280 to
322b286
Compare
carlos-granados
added
performance-check
carlos-granados
force-pushed
the
restore-ci-benchmark
branch
from
322b286 to
c16b321
Compare
carlos-granados
added
performance-check
carlos-granados
force-pushed
the
restore-ci-benchmark
branch
from
c16b321 to
05cfdb4
Compare
carlos-granados
removed
the
performance-check
carlos-granados
added
the
performance-check
carlos-granados
force-pushed
the
restore-ci-benchmark
branch
from
05cfdb4 to
d623879
Compare
carlos-granados
added
performance-check
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original Xdebug had a performance measuring mechanism that used the count of executed instructions instead of time. This is much more precise and does not depend on random conditions which can skew timings. This PR recovers this mechanism and runs a benchmark. This benchmark is then compared with two branches: the base branch for any pull request and a "base" branch which represents the original Xdebug and we produce two summaries with these two results
In order to run this performance checks we need to add the
performance-checklabel to any PR (this will also be run every week and can be run on demand)You can see a sample of the results here:
https://github.com/pronskiy/php-debugger/actions/runs/23285783251
(the improvement over the base branch for the pull request is empty because this has not yet been run on the "main" branch before)