Fix bugs: event handlers, variable shadowing, performance#2
Open
GabHST wants to merge 1 commit intopumpan:mainfrom
Open
Fix bugs: event handlers, variable shadowing, performance#2GabHST wants to merge 1 commit intopumpan:mainfrom
GabHST wants to merge 1 commit intopumpan:mainfrom
Conversation
- Fix variable shadowing: botCount, initialBotRemoved, firstBotName, messageQueue were declared twice with local - Fix restoreFrame shadowing: renamed second instance to refillRestoreFrame to prevent sound restore conflicts - Fix print() calls: replaced with DEFAULT_CHAT_FRAME:AddMessage() (print doesn't exist in 1.12.1) - Fix event handler signatures: MODIFIER_STATE_CHANGED handlers used named params instead of arg1/arg2 globals (1.12.1 API) - Fix GROUP_ROSTER_UPDATE: doesn't exist in 1.12.1, replaced with PARTY_MEMBERS_CHANGED - Fix tooltip anchors: Group Loot and Master Loot tooltips were anchored to FFA checkbox - Fix performance: moved buildGuildRoster() and buildFriendList() outside raid/party member loops - Fix totalHealers implicit global: added local keyword - Fix totaly implicit global: declared at file scope - Fix PresetPopup OnHide: removeButton:Show() -> Hide() when no preset selected - Fix "automaticaly" typo -> "automatically" - Remove duplicate generateTooltip/regenerateTooltips definitions in Presets.lua - Fix debugger timestamp: GetTimestamp() was defined but never called
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug fixes for FillRaidBots addon on WoW 1.12.1:
function(_, _, key, state)parameter style which doesn't work in 1.12.1 (args come from globalsarg1/arg2). Ctrl+Alt click-to-fill from boss target never worked. Fixed bothkeyboardFrameanddetectBossEventFramehandlers.PARTY_MEMBERS_CHANGED(RAID_ROSTER_UPDATE was already registered).botCount,initialBotRemoved,firstBotName,messageQueuedeclared twice withlocal, creating two independent sets. Code before line 249 used one set, code after used another. Removedlocalfrom second declarations.restoreFrameframes created.ToggleSoundEffectsVolume("restore")used the first,RefillBotsused the second. Renamed second torefillRestoreFrame.print()calls withDEFAULT_CHAT_FRAME:AddMessage()in both FillRaidBots.lua and debugger.lua.buildGuildRoster()andbuildFriendList()were called insidefor i = 1, GetNumRaidMembers()loop (up to 40x per check). Moved before the loop.totalHealersandtotalylackedlocal, polluting global namespace.removeButton:Show()when no preset selected, should beHide().GetTimestamp()was defined but never called inDebugMessage().generateTooltip/regenerateTooltipsdefinitions in Presets.lua (first pair was dead code).Test plan
/frbdebug— verify no Lua errors from print()