Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
…atch to MultipatchDiscreteDeRham
yguclu
requested changes
Nov 25, 2025
Member
yguclu
left a comment
There was a problem hiding this comment.
Good job @jowezarek!
I am posting a few comments below
yguclu
requested changes
Dec 9, 2025
Member
yguclu
left a comment
There was a problem hiding this comment.
Good job! I have just some minor comments.
Could you please add the license header to every new file?
yguclu
requested changes
Dec 11, 2025
yguclu
requested changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We implement preconditioners for mass matrices proposed by Loli, Sangalli & Tani in their paper Easy and efficient preconditioning of the isogeometric mass matrix. Fixes #525.
Obtaining LST preconditioner
Example 1: Working with a
DiscreteDeRhamobject.returns preconditioner for all four mass matrices. Obtaining only a subset works as follows:
When working with modified mass matrices
set the
hom_bcflag toTruein order to obtain the correct pcs:Use these preconditioner like so:
Example 2: Working with FEM objects only. Use the following function located in
linalg/tests/test_solvers.py.It returns a single LST preconditioner for the mass matrix provided.
Use like so
For more information, check out the new example in
examples/vector_potential_3d.py.Also, check out the test
linalg/tests/test_solvers.py::test_LST_preconditionerfor more information regarding their efficiency.