Raise TypeError when Dataset passed as data_vars to Dataset constructor#11139
Open
kkollsga wants to merge 2 commits intopydata:mainfrom
Open
Raise TypeError when Dataset passed as data_vars to Dataset constructor#11139kkollsga wants to merge 2 commits intopydata:mainfrom
kkollsga wants to merge 2 commits intopydata:mainfrom
Conversation
Dataset(ds) silently dropped attrs because Dataset inherits from Mapping, so the constructor iterated over data variable keys while ignoring attrs. This was never intended behavior. Raise TypeError with a message directing users to ds.copy() instead. Closes GH11095 Co-authored-by: Claude <noreply@anthropic.com>
kkollsga
force-pushed
the
fix-dataset-constructor-rejects-dataset
branch
from
d73c212 to
cf9685e
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whats-new.rstapi.rst(N/A - no new public API)Summary
Dataset(ds)silently dropped.attrsbecauseDatasetinherits fromMapping, so the constructor iterated over data variable keys while ignoring attributes. This was never intended behavior.This PR raises
TypeErrorwith a helpful message directing users tods.copy()instead, as discussed in #11095 with @keewis.Test plan
test_constructor_dataset_as_data_vars_raisesverifies the error is raised🤖 Generated with Claude Code