Open
Conversation
| cloned_outputs: list[Variable] | Variable | Out | list[Out] | ||
| if isinstance(outputs, list): | ||
| cloned_outputs = [] | ||
| cloned_outputs_list = [] |
Contributor
There was a problem hiding this comment.
Can cloned_outputs just be used?
Member
Author
There was a problem hiding this comment.
It wouldn't be type-stable and mypy doesn't like it. The problem is that if you declare it as list[T] | T it won't let you redeclare it as list[T].
Armavica
force-pushed
the
typing
branch
3 times, most recently
from
c7ba247 to
dee236c
Compare
Member
|
is this ready for review? Could you rebase it? I'd like to see it merged. |
Member
Author
|
Sorry for the delay, I had a rough last six months. I will rebase this PR |
Member
Author
|
@jessegrabowski Ready to review, likely to clash with #1983 but I don't mind rebasing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Checklist
Type of change