Config layer suggestion with registry #14
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the type of functionality I would like to have where you can generate the configuration in a modular way using the config classes directly and then create a registry object to browse and change the configuration. I have called the registry class for
Acceleratorto make it easier for MML users to understand since it corresponds to the functionality of theAcceleratorObjectin MML and contains all the information about the accelerator.I don't understand what is done with
FileRepositoryin theConfigServiceso I didn't dare to change anything there but my idea is that bothConfigServiceand theYellowPagesshould be replaced by something like this.The idea would then be that when generating the devices, the required config data should be extracted from the
Acceleratorand there would be a factory which creates either TANGO or EPICS devices based on the control system config.I also made some suggestion to changes for the devices because I think some of the names are not easy for most people to understand but I think more work is required to come up with good data models for devices.