[3.13] Add some doctest cleanups for configparser (GH-125288)#125290
Merged
AlexWaygood merged 2 commits intopython:3.13from Oct 11, 2024
Merged
[3.13] Add some doctest cleanups for configparser (GH-125288)#125290AlexWaygood merged 2 commits intopython:3.13from
configparser (GH-125288)#125290AlexWaygood merged 2 commits intopython:3.13from
Conversation
bedevere-app
bot
added
docs
Member
|
A |
zware
reviewed
Oct 11, 2024
Doc/library/turtle.rst
Outdated
Comment on lines
+19
to
+20
| import os | ||
| os.remove("my_drawing.ps") |
Member
There was a problem hiding this comment.
Two birds with one stone; the save feature is new in 3.14, and this works to kill the window after the tests for me locally:
Suggested change
| import os | |
| os.remove("my_drawing.ps") | |
| # Destroy the turtle window after tests are complete | |
| # Imported via star import in testsetup | |
| bye() |
Member
There was a problem hiding this comment.
#125294 (comment) -- this doesn't seem to do anything for me locally :/
for now I'll just revert the changes to turtle.rst and only backport the configparser.rst changes
AlexWaygood
changed the title
turtle and configparser (GH-125288)configparser (GH-125288)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit a726ce7 -- but only the
configparserchanges)Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com
Co-authored-by: Adam Turner 9087854+AA-Turner@users.noreply.github.com
📚 Documentation preview 📚: https://cpython-previews--125290.org.readthedocs.build/