gh-136728: Combine OpenSSL and AWS-LC CI configurations#144805
gh-136728: Combine OpenSSL and AWS-LC CI configurations#144805hugovk merged 9 commits intopython:mainfrom
Conversation
zware
added
tests
hugovk
left a comment
hugovk
left a comment
There was a problem hiding this comment.
Yeah, this approach also looks fine by me :)
Collapse matrix entries into more concise one line each.
Remove obsolete OpenSSL 1.1.1w; AWS-LC is roughly 1.1.1-shaped and exercises the relevant APIs.
Remove AWS-LC 1.55.0; just test the single latest version.
zware
requested review from
AA-Turner,
ezio-melotti,
gpshead,
picnixz and
webknjaz
as code owners
| ssllib: | ||
| # See Tools/ssl/make_ssl_data.py for notes on adding a new version | ||
| ## OpenSSL | ||
| - { name: openssl, version: 3.0.19 } |
There was a problem hiding this comment.
Nested objects in the matrix generally cause difficulties. So yes, that other PR solves this bit better. I understand the desire to couple libs with their versions and it might be reasonable to just use strings like openssl == 3.0.19 and split them where necessary.
…rations" This reverts commit 4676575.
Quote `${{ }}` substitutions in commands.
AWS-LC 1.68.0 is already out, might as well use it.
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
Ok for thoses changes. I don't know about the changes for GHA.
|
Can we backport this, if it's not too difficult? Will make future maintenance easier. |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Sorry, @zware and @hugovk, I could not cleanly backport this to |
|
It's apparently not that easy to backport :). I'll give it a try. |
…ythonGH-144805) (cherry picked from commit c9b96b1) Co-authored-by: Zachary Ware <zach@python.org>
|
GH-145397 is a backport of this pull request to the 3.14 branch. |
6 participants
I accidentally started this before finding GH-143940, but given the somewhat different approach I figured it was worth sharing anyway. If we prefer the GH-143940 approach, this can just be closed.