gh-144851: Fix __lazy_import__ crash with user-defined filters#144852
Open
johnslavik wants to merge 8 commits intopython:mainfrom
Open
gh-144851: Fix __lazy_import__ crash with user-defined filters#144852johnslavik wants to merge 8 commits intopython:mainfrom
__lazy_import__ crash with user-defined filters#144852johnslavik wants to merge 8 commits intopython:mainfrom
Conversation
Member
Author
|
Skipping news as this is still unreleased. |
johnslavik
changed the title
__lazy_import__ crash__lazy_import__ crash with user-defined filters
johnslavik
requested review from
DinoV,
Yhg1s,
brettcannon,
ericsnowcurrently,
kumaraditya303,
ncoghlan,
pablogsal and
warsaw
as code owners
Member
Author
|
Hold on, this flow is more complicated than I thought... |
Member
Author
|
OK, it's fine. All paths are good. 👍🏽 EDIT: I'm not sure we run all tests in CI. I'm adding a test to test the test. |
Member
Author
|
We're not running |
This reverts commit cbcd0b9.
This was referenced Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writing a test shortly, still in progress!
__lazy_import__crashes with user-defined filters #144851