Made parameters of collections.abc members positional only#15305
Open
randolf-scholz wants to merge 4 commits intopython:mainfrom
Open
Made parameters of collections.abc members positional only#15305randolf-scholz wants to merge 4 commits intopython:mainfrom
randolf-scholz wants to merge 4 commits intopython:mainfrom
Conversation
Contributor
Author
|
I guess the failure for 3.9 will resolve itself soon: #13782 |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
LGTM, once we drop 3.9. (I've marked this as deferred until then.) |
- Sequence - MutableSequence - AbstractSet - MutableSet - KeysView - ValuesView - ItemsView
119ce3d to
f85e9d3
Compare
Contributor
Author
|
Did a rebase to resolve conflicts (slice got updated and Additionally:
|
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: cwltool (https://github.com/common-workflow-language/cwltool)
+ cwltool/update.py: note: In function "v1_2to1_3dev1":
+ cwltool/update.py:55:25: error: Unexpected keyword argument "index" for "pop" of "MutableSequence" [call-arg]
+ ...typeshed_to_test/stdlib/typing.pyi:698:5: note: "pop" of "MutableSequence" defined here
pydantic (https://github.com/pydantic/pydantic)
- pydantic/_internal/_model_construction.py:308: error: Incompatible types in assignment (expression has type "Callable[[Any], bool]", base class "ABCMeta" defined the type as "def __instancecheck__(cls, instance: Any) -> bool") [assignment]
- pydantic/_internal/_model_construction.py:309: error: Incompatible types in assignment (expression has type "Callable[[type], bool]", base class "ABCMeta" defined the type as "def __subclasscheck__(cls, subclass: type) -> bool") [assignment]
jax (https://github.com/google/jax)
+ jax/_src/util.py:826: error: Unused "type: ignore" comment [unused-ignore]
+ jax/_src/util.py:827: error: Unused "type: ignore" comment [unused-ignore]
|
Contributor
Author
|
nice, the __instancecheck__ = type.__instancecheck__ # pyright: ignore[reportAssignmentType]
__subclasscheck__ = type.__subclasscheck__ # pyright: ignore[reportAssignmentType] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14071
It doesn't seem like this will be fixed in CPython (python/cpython#135312), so we should at least fix this in the stubs to prevent false positives like this: mypy-playground
Updated methods of the following types to only accept positional-only arguments:
2026-01-20 (@srittau): Marked as deferred, until tests for 3.9 are dropped (#13782).