Make SkipTest.__init__ reason positional-only#15703
Merged
JelleZijlstra merged 1 commit intopython:mainfrom May 6, 2026
Merged
Make SkipTest.__init__ reason positional-only#15703JelleZijlstra merged 1 commit intopython:mainfrom
SkipTest.__init__ reason positional-only#15703JelleZijlstra merged 1 commit intopython:mainfrom
Conversation
SkipTest does not override __init__ on any 3.x Python; it inherits BaseException.__init__(self, *args), where *args is positional-only at runtime. Without the / marker, the stub claims SkipTest(reason='x') is valid, but it raises TypeError at runtime.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SkipTest(reason="x")type-checks under the current stub but raisesTypeErrorat runtime, becauseSkipTestdoesn't override__init__and so inheritsBaseException.__init__(self, *args), where*argsis positional-only.SkipTesthas never defined its own__init__on any 3.x version:So the override at
stdlib/unittest/case.pyi:57narrows the inherited variadic to one argument but drops the positional-only marker, which makes the stub admit calls the runtime rejects.Adding
, /keeps the documented "one reason string" narrowing while bringing the call shape back in line with the runtime.