Skip to content

Op registry to warn instead of error against duplicated op s (#18179)#18179

Open
rezaasjd wants to merge 1 commit intopytorch:mainfrom
rezaasjd:export-D96544230
Open

Op registry to warn instead of error against duplicated op s (#18179)#18179
rezaasjd wants to merge 1 commit intopytorch:mainfrom
rezaasjd:export-D96544230

Conversation

@rezaasjd
Copy link

@rezaasjd rezaasjd commented Mar 13, 2026

Summary:

Resolves the issue where duplicated primitive ops can be attempted to be registered from multiple ET runners.
The error can be silent in pre-main static intialization.

Differential Revision: D96544230

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 13, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18179

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Awaiting Approval, 1 New Failure, 1 Unrelated Failure

As of commit 8067d67 with merge base e729fa7 (image):

AWAITING APPROVAL - The following workflow needs approval before CI can run:

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

  • pull / test-binary-size-linux-gcc / linux-job (gh) (trunk failure)
    /pytorch/executorch/kernels/portable/cpu/op_convolution.cpp:175:41: error: comparison of integer expressions of different signedness: ‘ssize_t’ {aka ‘long int’} and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 13, 2026
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Mar 13, 2026

@rezaasjd has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96544230.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…#18179)

Summary:

Resolves the issue where duplicated primitive ops can be attempted to be registered from multiple ET runners.
The error can be silent in pre-main static intialization.

Differential Revision: D96544230
@meta-codesync meta-codesync bot changed the title Op registry to warn instead of error against duplicated op s Op registry to warn instead of error against duplicated op s (#18179) Mar 14, 2026
@kirklandsign
Copy link
Contributor

What's the use case of multiple runners?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants