CAMX: Add static lib as part of tarball

[gkhose-qipl]

Include the static library (.a) in the generated tarball for consumers requiring static linking.

[anujm1]

Include the static library (.a) in the generated tarball for consumers
requiring static linking.
Move linker flags into CMake and drop recipe EXTRA_OECMAKE linker flags.
Install the library directly to the correct path via CMake instead of
moving it post-install in the recipe.

I didn't understand. Which EXTRA_OECMAKE? What is this describing?

[gkhose-qipl]

Include the static library (.a) in the generated tarball for consumers
requiring static linking.
Move linker flags into CMake and drop recipe EXTRA_OECMAKE linker flags.
Install the library directly to the correct path via CMake instead of
moving it post-install in the recipe.

I didn't understand. Which EXTRA_OECMAKE? What is this describing?

The flags listed below were previously used in the recipe, but we have now updated the CMake file. The removal was Needed due to one comment on PR. https://github.com/qualcomm-linux/meta-qcom-extras/pull/72
EXTRA_OECMAKE += "
-DCMAKE_EXE_LINKER_FLAGS='-L${STAGING_LIBDIR}/camx/talos'
-DCMAKE_SHARED_LINKER_FLAGS='-L${STAGING_LIBDIR}/camx/talos' \

[anujm1]

The flags listed below were previously used in the recipe, but we have now updated the CMake file. The removal was Needed due to one comment on PR. qualcomm-linux/meta-qcom-extras#72
EXTRA_OECMAKE += " -DCMAKE_EXE_LINKER_FLAGS='-L${STAGING_LIBDIR}/camx/talos' -DCMAKE_SHARED_LINKER_FLAGS='-L${STAGING_LIBDIR}/camx/talos' \

Thanks. Please reword your commit messages to explain changes being brought in the new version and not in a recipe in extras layer. If new version has fixed cmake files in code so it doesn't require hardcoded absolute paths, please say that.

[lumag]

Move linker flags into CMake and drop recipe EXTRA_OECMAKE linker flags.
Install the library directly to the correct path via CMake instead of
moving it post-install in the recipe.

Please don't describe non-visible changes. They are of no concern to the users of your tarballs.

[ricardosalveti]

Please be specific in your commit message, and only describe the changed behavior which is relevant for consumers of this recipe.

[koenkooi]

Can you change the PR title and description to match your commits? The merge commit will be confusing otherwise.

[gkhose-qipl]

Can you change the PR title and description to match your commits? The merge commit will be confusing otherwise.

done

[gkhose-qipl]

@ricardosalveti / @lumag /@anujm1 / @koenkooi ,
can you please review.

[ricardosalveti]

Mind rebasing to the latest master?

[gkhose-qipl]

Mind rebasing to the latest master?

done

[github-actions]

Test run workflow

Test jobs for commit 91525a7

Test	dragonboard-820c	qcs615-adp-air	qcs6490	qcs8300	qcs9100	qcs9100-rb8	qrb2210-rb1
AudioRecord	🚫	✅ pass	✅ pass	✅ pass	✅ pass	🚫	✅ pass
BT_FW_KMD_Service	🚫	🚫	❌ fail	✅ pass	✅ pass	✅ pass	✅ pass
BT_ON_OFF	🚫	⚠️ skip	✅ pass	✅ pass	✅ pass	⚠️ skip	✅ pass
BT_SCAN	🚫	🚫	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
CPUFreq_Validation	🚫	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
DSP_AudioPD	🚫	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
Ethernet	🚫	⚠️ skip	🚫	⚠️ skip	✅ pass	⚠️ skip	⚠️ skip
Interrupts	🚫	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
KMSCube	🚫	⚠️ skip	⚠️ skip	✅ pass	⚠️ skip	⚠️ skip	✅ pass
OpenCV	🚫	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
WiFi_Firmware_Driver	🚫	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
WiFi_OnOff	🚫	⚠️ skip	✅ pass	✅ pass	✅ pass	⚠️ skip	✅ pass
adsp_remoteproc	🚫	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
boot	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
cdsp_remoteproc	🚫	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	⚠️ skip
core_auth	🚫	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
fastrpc_test	🚫	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	🚫
hotplug	🚫	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
irq	🚫	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass	✅ pass
weston-simple-egl	🚫	⚠️ skip	⚠️ skip	✅ pass	⚠️ skip	⚠️ skip	✅ pass

All jobs summary

Job ID	Device	State	Health
173679	qcs6490	Finished	Complete
173696	qcs9100	Finished	Complete
173652	qcs615-adp-air	Finished	Complete
173657	qcs6490	Finished	Complete
173705	qcs9100	Finished	Complete
173673	qcs9100-rb8	Finished	Complete
173660	dragonboard-820c	Finished	Complete
173644	qcs8300	Finished	Complete
173677	qrb2210-rb1	Finished	Complete
173648	qcs6490	Finished	Complete
173676	qcs6490	Finished	Complete
173662	qrb2210-rb1	Finished	Complete
173681	qcs8300	Finished	Complete
173642	qrb2210-rb1	Finished	Complete
173691	qrb2210-rb1	Finished	Complete
173684	qcs9100	Finished	Complete
173668	qcs9100-rb8	Finished	Complete
173646	dragonboard-820c	Finished	Complete
173697	qcs8300	Finished	Complete
173674	qcs8300	Finished	Complete
173678	qcs615-adp-air	Finished	Incomplete
173704	qcs6490	Finished	Complete
173689	qcs9100-rb8	Finished	Complete
173647	qcs8300	Finished	Complete
173653	qcs8300	Finished	Complete
173693	qcs6490	Finished	Complete
173641	qcs8300	Finished	Complete
173699	qcs8300	Finished	Complete
173658	qrb2210-rb1	Finished	Complete
173702	qcs9100-rb8	Finished	Complete
173654	qcs615-adp-air	Finished	Complete
173688	qcs615-adp-air	Finished	Complete
173687	qrb2210-rb1	Finished	Complete
173661	qcs9100	Finished	Complete
173667	qcs6490	Finished	Complete
173700	qcs9100	Finished	Complete
173698	qcs9100-rb8	Finished	Complete
173663	qcs6490	Finished	Complete
173682	qcs6490	Finished	Complete
173650	qcs9100	Finished	Complete
173694	qcs9100	Finished	Complete
173686	qcs615-adp-air	Finished	Complete
173656	qcs615-adp-air	Finished	Complete
173659	qcs9100-rb8	Finished	Complete
173680	qcs615-adp-air	Finished	Complete
173701	qrb2210-rb1	Finished	Complete
173685	qrb2210-rb1	Finished	Complete
173703	qcs615-adp-air	Finished	Complete
173670	qcs615-adp-air	Finished	Incomplete
173690	qcs6490	Finished	Complete
173649	dragonboard-820c	Finished	Complete
173651	qcs9100-rb8	Finished	Complete
173695	qcs9100	Finished	Complete
173672	qcs9100-rb8	Finished	Complete
173683	qcs9100-rb8	Finished	Complete
173675	qcs8300	Finished	Complete
173692	qcs8300	Finished	Complete
173666	qcs615-adp-air	Finished	Complete
173664	qcs9100	Finished	Complete
173643	qcs9100-rb8	Finished	Complete
173665	qcs9100	Finished	Complete
173645	qrb2210-rb1	Finished	Complete
173671	qrb2210-rb1	Finished	Complete
173655	dragonboard-820c	Finished	Complete

[test-reporting-app]

Test Results

   64 files  +  1    286 suites  +15   4h 15m 6s ⏱️ + 10m 52s
   61 tests  -   2     55 ✅ + 20   0 💤 ±0   6 ❌  - 22 
2 696 runs  +174  2 656 ✅ +206  25 💤 +8  15 ❌  - 40 

For more details on these failures, see this check.

Results for commit 91525a7. ± Comparison against base commit 303b4f6.

This pull request removes 2 tests.

lava ‑ auto-login-action
lava ‑ minimal-boot