Add GStreamer AI_ML test suite#279
Conversation
|
@vijpatel22 Please update the script's execute permissions and address the errors reported by shelllint. https://github.com/qualcomm-linux/qcom-linux-testkit/actions/runs/21785074948/job/62885941654?pr=279 |
|
Hi @smuppand, I’ve pushed the latest changes. Could you please review. |
vijpatel22
force-pushed
the
feature/gstreamer-ai-ml
branch
from
ce24ad8 to
6479657
Compare
|
Hi @smuppand, I’ve addressed the comments and updated the code based on the feedback. Could you please review the changes? |
|
@vijpatel22 Please rebase and resolve the conflicts |
|
Hi @smuppand, I’ve resolved the merge conflicts and updated the branch accordingly |
vijpatel22
force-pushed
the
feature/gstreamer-ai-ml
branch
from
97e28d3 to
2cb7be4
Compare
|
@vijpatel22 Could you please address the workflow issues that have been reported? |
vijpatel22
force-pushed
the
feature/gstreamer-ai-ml
branch
3 times, most recently
from
d080921 to
21249c3
Compare
This PR still contains unrelated commits, making the review hard. Please clean it up with a proper rebase. |
|
Hi @smuppand, shall I clean up all history and force‑push a new clean commit to this PR branch? |
Hi @vijpatel22 , yes — please do a proper interactive rebase and force-push a clean branch. This PR should contain only the AI_ML suite and the minimal shared lib_gstreamer changes needed for it. Please remove unrelated changes from this PR, rebase on latest main, and ensure the workflow issues are fixed so CI passes. After that cleanup, we can continue with the functional review. |
Signed-off-by: Vij Patel <vijpatel@qti.qualcomm.com>
vijpatel22
force-pushed
the
feature/gstreamer-ai-ml
branch
from
21249c3 to
8330dde
Compare
|
Hi @smuppand, |
smuppand
left a comment
smuppand
left a comment
There was a problem hiding this comment.
the new lib_gstreamer.sh additions should stay generic. In particular, run_pipeline_with_logs() should not hardcode suite-specific log paths if we want it to be reusable across other GSTreamer suites.
|
It make sense if the lib_gstreamer.sh helper additions are intentionally being introduced as broadly reusable helpers beyond AI_ML. In that case, i would suggest to split into two commits commit 1: generic lib_gstreamer.sh helper additions commit 2: AI_ML suite files |
Signed-off-by: Vij Patel <vijpatel@qti.qualcomm.com>
Signed-off-by: Vij Patel <vijpatel@qti.qualcomm.com>
|
Hi @smuppand, |
smuppand
left a comment
smuppand
left a comment
There was a problem hiding this comment.
Commit structure:
- This should stay split, but as 2 commits, not 3:
- generic
Runner/utils/[lib_gstreamer.sh](http://lib_gstreamer.sh/)helper additions GSTreamer/AI_MLsuite files (AI_ML.yaml,[run.sh](http://run.sh/),[Readme.md](http://readme.md/))
- generic
Suggested commit subjects:
Runner/utils: add reusable GStreamer AI/ML helper functionsGSTreamer/AI_ML: add AI/ML pipeline validation suite
| fi | ||
| TIMEOUT=60 # seconds | ||
| # ENCODED_VIDEO_PATH=''"${test_path}"'/video_out.mp4' | ||
| ENCODED_VIDEO_PATH='./video_out.mp4' |
There was a problem hiding this comment.
Please create the parent directory for ENCODED_VIDEO_PATH so custom output paths do not fail:
|
|
||
| log_info "Running ${name} (timeout=${TIMEOUT}s)" | ||
| # Check if timeout command is available | ||
| if ! command -v timeout >/dev/null 2>&1; then |
There was a problem hiding this comment.
Please prefer the repo timeout helper path first and only fall back to GNU timeout if needed.
2 participants
PR – Add AI/ML GStreamer Test Suite
Overview
This pull request introduces, a self‑contained test suite for the AI/ML GStreamer suite located at:
Runner/suites/Multimedia/GStreamer/AI_ML/run.sh
The script automates the end‑to‑end validation of object‑detection and image‑classification pipelines that leverage Qualcomm‑specific GStreamer plugins.
It will:
🛠️ What’s Added / Modified
Runner/suites/Multimedia/GStreamer/AI_ML/run.sh- New executable script (the full implementation is attached in this PR).Runner/suites/Multimedia/GStreamer/AI_ML/AI_ML.yaml- New YAML fileRunner/suites/Multimedia/GStreamer/AI_ML/Readme.md- New Readme fileRunner/utils/lib_gstreamer.sh- Added new functions.