Audio: fix/update record-playback test to use shared recorded directory#367
Merged
smuppand merged 2 commits intoqualcomm-linux:mainfrom Mar 29, 2026
Merged
Conversation
smuppand
requested changes
Mar 24, 2026
Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/run.sh
Outdated
Show resolved
Hide resolved
Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/Audio_Record_Playback.yaml
Outdated
Show resolved
Hide resolved
Contributor
Author
smuppand
requested changes
Mar 25, 2026
| @@ -21,6 +22,26 @@ run: | |||
| steps: | |||
| - REPO_PATH="$PWD" | |||
| - cd Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/ | |||
Contributor
There was a problem hiding this comment.
Please use the repo-standard path form here:
- REPO_PATH="$PWD"
- cd "$REPO_PATH/Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback"
The current relative cd Runner/... form is not aligned with the usual test definition pattern.
Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/Audio_Record_Playback.yaml
Outdated
Show resolved
Hide resolved
Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/Audio_Record_Playback.yaml
Outdated
Show resolved
Hide resolved
Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/Audio_Record_Playback.yaml
Outdated
Show resolved
Hide resolved
Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/Audio_Record_Playback.yaml
Outdated
Show resolved
Hide resolved
Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/run.sh
Outdated
Show resolved
Hide resolved
Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/run.sh
Outdated
Show resolved
Hide resolved
Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/run.sh
Outdated
Show resolved
Hide resolved
Contributor
Author
Contributor
|
@nitinn22 I would suggest squashing the commits for cleaner history |
smuppand
requested changes
Mar 27, 2026
Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/README.md
Outdated
Show resolved
Hide resolved
- Use common recorded directory across audio tests - Update run.sh and YAML for consistent folder handling - Allow individual test execution - Address review feedback# This is the 1st commit message: Audio: fix/update record‑playback test to use shared recorded directory Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com> addressed comments related to making common util for folder handling for video and audio Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com> added individual test case run possibility for audio suite Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com> Modified yaml file to handle common directory structure for files Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com> Modified run sh file to handle common dir Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com> Modified Audio scripts based on comments received Signed-off-by: nitinn <nitinn@qti.qualcomm.com> audio: address final review comments Signed-off-by: nitinn <nitinn@qti.qualcomm.com>
nitinn22
force-pushed
the
feature/audio-record-playback-fix-clean
branch
from
5a40b13 to
37ac48e
Compare
Contributor
Author
smuppand
requested changes
Mar 29, 2026
Contributor
smuppand
left a comment
smuppand
left a comment
There was a problem hiding this comment.
Only the three README fixes are still outstanding. Everything else looks fine.
Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/README.md
Outdated
Show resolved
Hide resolved
Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/README.md
Outdated
Show resolved
Hide resolved
Runner/suites/Multimedia/GSTreamer/Audio/Audio_Record_Playback/README.md
Outdated
Show resolved
Hide resolved
Signed-off-by: nitinn <nitinn@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Audio Record / Playback test updates only.
Changes
Audio_Record_Playback.yamlto use shared recorded directoryrun.shfor consistent record/playback handlingNotes
Validation