display: add DRM helpers and fix core_auth skip handling #372
display: add DRM helpers and fix core_auth skip handling #372smuppand wants to merge 2 commits intoqualcomm-linux:mainfrom
Conversation
Update Runner/utils/lib_display.sh to add two reusable display helpers: - get_drm_primary_node() Returns the first available DRM primary node under /dev/dri/card* so display and IGT tests can detect primary DRM availability consistently. - weston_cleanup_stale_sockets() Removes stale Wayland socket files only when Weston is not running, using best-effort cleanup for common Weston runtime locations. These helpers improve reuse across display-related tests and remove runtime noise from Weston stop/start paths without changing normal execution flow. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
|
@vsalipal - Please review this as well. I was unable to add you as an assignee, possibly because you are not part of the qualcomm-linux group. |
|
I don't like this patch. It seems to be masking the root cause of the issue instead of fixing it. |
Thanks for the feedback. The |
I’ve updated the patch to remove the proactive DRM-node skip. The runner now only logs which DRM primary node is being used when present, or warns if none is found, and still lets core_auth run and determine the actual outcome itself. So the patch stays focused on:
|
Update the core_auth runner to preserve IGT skip semantics without adding a runner-side skip gate. Changes in this update: - use get_drm_primary_node() only for diagnostic logging - log the DRM primary node when present - warn and continue when no DRM primary node is found - treat IGT rc=77 as SKIP instead of FAIL - keep other non-zero return codes as FAIL Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
2 participants
This PR adds reusable display helpers in lib_display.sh and updates the core_auth runner to report skip-only cases correctly. Also addressed the issue #327
Summary
This fixes incorrect FAIL results in headless or display-disconnected LAVA runs while keeping normal manual runs unchanged.
Results with these changes:
https://lava.infra.foundries.io/scheduler/job/166573
https://lava.infra.foundries.io/scheduler/job/166574