Skip to content

Modified audio gst suite to handle test case name fix#382

Merged
smuppand merged 2 commits intoqualcomm-linux:mainfrom
nitinn22:feature/audio-record-playback-fix-clean
Apr 2, 2026
Merged

Modified audio gst suite to handle test case name fix#382
smuppand merged 2 commits intoqualcomm-linux:mainfrom
nitinn22:feature/audio-record-playback-fix-clean

Conversation

@nitinn22
Copy link
Copy Markdown
Contributor

@nitinn22 nitinn22 commented Apr 1, 2026

Description

This PR fixes the "Unexpected test result" errors in LAVA by implementing flexible test case naming for the GStreamer Audio_Record_Playback test suite.

Problem

LAVA was reporting "Unexpected test result" errors because:

  • The Audio test script was hardcoding the test name as Audio_Record_Playback in the .res file
  • LAVA expected specific test names like GStreamer_Audio_Record_wav based on the job definition
  • This mismatch caused LAVA to report passing tests as failures

Solution

Implemented a flexible test naming mechanism that allows LAVA to override the test case name:

  1. Added RESULT_TESTNAME variable - Defaults to Audio_Record_Playback but can be overridden
  2. Added --lava-testcase-id parameter - Allows LAVA to specify the expected test case name
  3. Added LAVA_TESTCASE_ID YAML parameter - Passes the test case name from LAVA job definition to the script
  4. Updated all error handling - Changed all .res file writes to use $RESULT_TESTNAME instead of $TESTNAME

Files Changed

Audio Test Suite (Audio_Record_Playback):

  • Audio_Record_Playback.yaml:

    • Added LAVA_TESTCASE_ID: "Audio_Record_Playback" parameter
    • Updated run.sh invocation to pass --lava-testcase-id "${LAVA_TESTCASE_ID}"
  • run.sh:

    • Added RESULT_TESTNAME="$TESTNAME" variable (line 41)
    • Added --lava-testcase-id parameter handler in argument parsing
    • Updated 20+ locations where .res file is written to use $RESULT_TESTNAME
    • Updated help section with new parameter documentation
  • README.md:

    • Documented --lava-testcase-id parameter in Options section
    • Added LAVA_TESTCASE_ID to LAVA Environment Variables section
    • Added "LAVA Test Case Naming" section with examples

Signed-off-by: nitinn <nitinn@qti.qualcomm.com>
@nitinn22
Copy link
Copy Markdown
Contributor Author

nitinn22 commented Apr 1, 2026

Signed-off-by: nitinn <nitinn@qti.qualcomm.com>
Copy link
Copy Markdown
Contributor

@smuppand smuppand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smuppand smuppand merged commit acf63f6 into qualcomm-linux:main Apr 2, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants