Skip to content

Expand =/$SYSROOT for INPUT/GROUP script commands#950

Open
parth-07 wants to merge 2 commits intoqualcomm:mainfrom
parth-07:SysrootExpansion
Open

Expand =/$SYSROOT for INPUT/GROUP script commands#950
parth-07 wants to merge 2 commits intoqualcomm:mainfrom
parth-07:SysrootExpansion

Conversation

@parth-07
Copy link
Copy Markdown
Contributor

This commit improves the script parser to expand
the = and $SYSROOT prefix in INPUT/GROUP inputs.

Resolves #927

@parth-07 parth-07 force-pushed the SysrootExpansion branch 3 times, most recently from b5640a0 to c91146e Compare March 18, 2026 09:33
Copy link
Copy Markdown
Contributor

@quic-seaswara quic-seaswara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very cool feature!

void ScriptParser::addFile(StringRef Name) {
StrToken *InputStrTok = nullptr;
if (Name.consume_front("-l"))
InputStrTok = ThisScriptFile.createNameSpecToken(Name.str(),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does ld for namespec files ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find any difference in interpretation for namespec files with explicit sysroot in GNU ld.

This commit improves the script parser to expand
the = and $SYSROOT prefix in INPUT/GROUP inputs.

Resolves qualcomm#927

Signed-off-by: Parth Arora <partaror@qti.qualcomm.com>
Signed-off-by: Parth <partaror@qti.qualcomm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

= and $SYSROOT in INPUT|GROUP command does not expand to SYSROOT

2 participants