autobib: fix sorting of author-less books#549
Conversation
Convert title using content->string before it may be used as a sortable name.
ad9383e to
3a4ec99
Compare
There was a problem hiding this comment.
Resyntax analyzed 1 file in this pull request and found no issues.
There was a problem hiding this comment.
Resyntax analyzed 1 file in this pull request and found no issues.
|
@mflatt is this right, or should the |
|
I think you're right that There's a use of |
|
I'll move the fix to Also—should I use |
There was a problem hiding this comment.
Resyntax analyzed 1 file in this pull request and found no issues.
|
Your revised changes look good to me. Here's an example that works both before and after your changes, but doesn't work if I only adjust |
|
I'm willing to add this change, if you tell me how to test it. Otherwise, LGTM. I think that the test that @bennn added in the commit you mentioned might already test this case, though. |
|
Ping? I think the change is good as-is and that the existing test works. |
|
Sorry - I did lose track of this. Now that I try looking again, I agree that Ben's existing test does cover the change as needed. But the existing test doesn't pass with the changes, yet: I overlooked that (I'd push that change and merge the PR, but I don't have write access.) |
|
Fixed. I didn't know this recipe to run tests (and only from the scribble-test directory or below, it seems). Thanks! |
There was a problem hiding this comment.
Resyntax analyzed 1 file in this pull request and found no issues.
Convert title using content->string before it may be used as a sortable name by autobib.