fix(ChatInput): add data-analytics-name to action bar buttons#3308
Open
rzp-slash[bot] wants to merge 4 commits intomasterfrom
Open
fix(ChatInput): add data-analytics-name to action bar buttons#3308rzp-slash[bot] wants to merge 4 commits intomasterfrom
rzp-slash[bot] wants to merge 4 commits intomasterfrom
Conversation
rzp-slash
Bot
requested review from
anuraghazra,
chaitanyadeorukhkar,
kamleshchandnani,
ravikumar-rajagopalan,
saurabhdaware,
swapnil-kr1 and
tewarig
as code owners
🦋 Changeset detectedLatest commit: 7f441da The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
✅ PR title follows Conventional Commits specification. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7f441da:
|
…s attrs - Add missing trailing newline to ChatInputActionBar.tsx (fixes prettier lint) - Update ChatInput.web.test.tsx.snap to include data-analytics-name attrs on the upload file Link and submit Button elements Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…utes Snapshots for ChatInput.ssr.test.tsx were failing because the new data-analytics-name attributes added to the Upload file link and Submit button in ChatInputActionBar weren't reflected in the stored snapshots. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RazorAnalytics was throwing a "Missing Name" error for the interactive elements inside
ChatInputActionBar— the Upload file link-button, the Submit button, and the Stop button — because none of them had adata-analytics-nameattribute.Blade's analytics utility (
makeAnalyticsAttribute) forwardsdata-analytics-*attributes to the DOM/native layer. RazorAnalytics then readsdata-analytics-nameto identify the element; when it's absent, it logs the "Missing Name" error.Fix
Added
data-analytics-nameto all three interactive elements inChatInputActionBar.tsx:data-analytics-namechat-input-upload-filechat-input-submitchat-input-stopTesting
ChatInputis rendered.🤖 Generated with Claude Code